Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: plex integration #1342

Merged
merged 16 commits into from
Oct 23, 2024
Merged

feat: plex integration #1342

merged 16 commits into from
Oct 23, 2024
+190 −12

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Oct 20, 2024 •
edited
Loading


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Oct 20, 2024 •
edited
Loading

Here's the code health analysis summary for commits 30d4464..b1637f9. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@hillaliy hillaliy self-assigned this Oct 20, 2024
@hillaliy hillaliy added the enhancement New feature or request label Oct 20, 2024
@hillaliy hillaliy marked this pull request as ready for review October 21, 2024 12:39
@hillaliy hillaliy requested a review from a team as a code owner October 21, 2024 12:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.78% 14654 / 37782
🔵 Statements 38.78% 14654 / 37782
🔵 Functions 35.94% 381 / 1060
🔵 Branches 70.88% 1300 / 1834
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/integrations/src/index.ts 100% 100% 100% 100%
packages/integrations/src/base/creator.ts 66.07% 100% 0% 66.07% 25-31, 33-34, 37, 40-48
packages/integrations/src/plex/interface.ts 0% 0% 0% 0%
packages/integrations/src/plex/plex-integration.ts 11.62% 100% 0% 11.62% 12, 14-19, 21-23, 26-29, 31-35, 37-39, 41-59, 61-62, 65, 67-85, 88-89, 92-102
packages/widgets/src/media-server/index.ts 100% 100% 100% 100%
Generated in workflow #3376 for commit b1637f9 by the Vitest Coverage Report Action

@hillaliy
Copy link
Contributor Author

I need some help to fix lint error

@manuel-rw
Copy link
Member

You should move @types/xml2js to devDependencies because it's never needed in the production. It's only used when TypeScript builds / lints the app.

@hillaliy
Copy link
Contributor Author

sorry for many commits

SeDemal
SeDemal requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@SeDemal SeDemal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to try it much, but I found this: https://plexapi.dev/Intro
I'm not sure if it actually is native plex or for a plugin, but they seem to handle the responses as JSON, and they provide an sdk.
The xml2js option is good enough, I'm just saying it's worth looking into.

packages/integrations/src/plex/plex-integration.ts Outdated Show resolved Hide resolved
packages/integrations/src/plex/plex-integration.ts Outdated Show resolved Hide resolved
packages/integrations/src/plex/interface.ts Outdated Show resolved Hide resolved
packages/integrations/src/plex/plex-integration.ts Outdated Show resolved Hide resolved
packages/integrations/src/plex/plex-integration.ts Outdated Show resolved Hide resolved
packages/integrations/src/plex/plex-integration.ts Outdated Show resolved Hide resolved
manuel-rw
manuel-rw previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@manuel-rw manuel-rw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for other reviewers to approve

@hillaliy hillaliy merged commit cf9b058 into dev Oct 23, 2024
10 checks passed
@hillaliy hillaliy deleted the plex-integration branch October 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeDemal SeDemal SeDemal approved these changes

@manuel-rw manuel-rw Awaiting requested review from manuel-rw

Assignees

@hillaliy hillaliy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hillaliy @manuel-rw @SeDemal